search

LearnBoost / websocket.io

329 stars 59 forks source link

Leverage ws parsers #23

Closed rauchg closed 12 years ago

nicokaiser commented 12 years ago

Do you mean something like this?

https://github.com/nicokaiser/websocket.io/commit/3ebc2c8280be69137fdcfa5fa1c7e4ad480f3766

(see https://github.com/nicokaiser/websocket.io/tree/wsparsers )

rauchg commented 12 years ago

Indeed!

nicokaiser commented 12 years ago

However it renders the parser tests useless, so I removed them. Then again, the ws parser is tested in the ws module itself...

rauchg commented 12 years ago

Yep that's good. websocket.io is an interface, so we should test the interface.

nicokaiser commented 12 years ago

(btw, I took most of the code from @einaros' socket.io fork)

einaros commented 12 years ago

That's exactly why I added the handleUpgrade() method in WebSocketServer back in january. :)