search

LearnGraphicsProgramming / Tag2D

(todo)
MIT License
3 stars 0 forks source link

Submodule missing premake5.lua script #2

Closed lexzor closed 2 months ago

lexzor commented 2 months ago

It seems the submodule glfw it's missing the premake5.lua script.

image

Reproduce the error by deleting the repo from local then clone it again.

lexzor commented 2 months ago

Solved by adding the premake5.lua file from @CMDR-JohnAlex glfw repository under client/external/glfw after fetching the git module.

It seems the configuration has been broke by the commit 1c91ac12dde3081874789cb0b46d60e416d33e7f .

An idea i think would be to have static files of premake5.lua for our external libraries and add the official repos as a submodule (both glad, glfw and future libraries).

DaaaPaul commented 2 months ago

Firstly im sorry thats my bad because I did that commit, I wasn't thinking clearly, I will learn from that.

But yes if Im understanding correctly I agree to have official repos as submodules, because currently it is glfw as submodule but not glad, and that is inconsistent.

CMDR-JohnAlex commented 2 months ago

glad has a repository, but it is only the generator and not the code we want. glad files are loaded with the OpenGL version you need with any extensions or options you choose from https://glad.dav1d.de/. Sadly means we can't use it as a submodule, but I plan to make any other third party tools like ImGUI to use submodules in future.

An idea i think would be to have static files of premake5.lua for our external libraries and add the official repos as a submodule (both glad, glfw and future libraries).

True... that might be nicer actually. I've always just used my fork because then I can be sure my premake file is working every time I sync with the official glfw repository, and then I just need to clone or add my repo as a submodule and not have to worry about the premake files or if something will break.

DaaaPaul commented 2 months ago

It seems that now this issue is fixed?

When I run git submodule update --init --recursive --remote --force it also clones the premake5.lua

CMDR-JohnAlex commented 2 months ago

Yup, fixed by e29f653566f8fab94e9011c9895035451755ca2e.