search

LearnLib / automatalib

A free, open-source Java library for modeling automata, graphs, and transition systems
http://automatalib.net
Apache License 2.0
92 stars 34 forks source link

Fixed Inverted Determinization Logic for BricsDFA Construction #31

Closed havrikov closed 5 years ago

havrikov commented 5 years ago

This change makes the code slightly less confusing to read.
(Although I'm pretty sure this will not change behavior because the correct check is done inside of BasicOperations.determinize(); as well.)

mtf90 commented 5 years ago

Whoops. Good catch! I think the reason, this works out most of the time is because most of the automatically constructed Brics automata (e.g. from regular expressions) are already determinized. However, this does not hold for all (manually) constructed automata, so this is a proper bug (-fix).

I'll add a test for checking this. Thanks for contributing!