LearnLib / automatalib

A free, open-source Java library for modeling automata, graphs, and transition systems
http://automatalib.net
Apache License 2.0
92 stars 34 forks source link

Fix a bug in the TarjanSCCVisitor regarding the stack ordering #35

Closed mmuesly closed 5 years ago

mmuesly commented 5 years ago

While working with the automata lib, I came across another bug related to #21.

There are cases, where the sccId is not uniform for a single SCC at the end. Instead, the stack ordering is the most important thing. It is possible that a single SCC is constructed using more than one sccID on the stack. Luckily, it is possible to recreate the stack order in the visitor by sorting the records on the stack by the number attribute.

A new test case affected by this problem is added as part of this PR.