search

LearnLib / automatalib

A free, open-source Java library for modeling automata, graphs, and transition systems
http://automatalib.net
Apache License 2.0
92 stars 34 forks source link

Add comments and remove redundant code in PaigeTarjan #60

Closed jn1z closed 11 months ago

jn1z commented 11 months ago

Minor changes to PaigeTarjan classes for maintainability and to help new users. Similar refactors could be made to OneSEVPAMinimizer, but that might require changing visibility levels.

jn1z commented 11 months ago

Great, thank you! The library is an impressive piece of work; glad I can help out.

mtf90 commented 11 months ago

The code-analysis has struck :laughing:. You can run the tests locally by using the -Pcode-analysis profile, e.g. mvn clean install -Pcode-analysis -pl util (you don't need to analyze the whole project if you only changed files in the util module).

mtf90 commented 11 months ago

I actually took your comment regarding the OneSEVPAMinimizer to heart, and refactored the block update method in 4630310 to a public method on the PaigeTarjan class. Now the code can be shared with the OneSEVPAMinimizer as well. Unfortunately, for the creation of new blocks the generic PaigeTarjanInitializers class use a Map whereas the OneSEVPAMinimizer class uses an array, so there is not so much too share.

Thanks again for your input!

jn1z commented 11 months ago

I actually took your comment regarding the OneSEVPAMinimizer to heart, and refactored the block update method

That's a great refactor!