kostis
commented
1 year ago Can we somehow split this into easy cases and ones that remain in the PR?
We can definitely do that, perhaps by cherry-picking the commits. But the problem is to agree what is easy (or not and why). To me, all changes are "obvious improvements". The only thing that I am unsure of is whether we can go ahead and remove more code instead of just commenting it out.
fhowar
It is no surprise that there is a lot of unused/unnecessary code in the code base. Such code was due to either attempts to fix things that did not lead anywhere or copy-pasting from another file without subsequent cleanups. Unused code is confusing and also adds (unnecessary) runtime overheads. It's better to remove or comment out this code, and I've used my best judgement to choose between these two options. Perhaps this PR can be improved in this respect (e.g. by removing some code that this first attempt just comments out).
While at it, the PR also fixes some small copy-paste errors (e.g. not checking a test, but repeating a prior test), removes some lines and does some cosmetic cleanups in methods and files which were touched.