search

LearnLib / ralib

Apache License 2.0
4 stars 2 forks source link

Upgrade to learnlib 0.17.0 #52

Closed kostis closed 9 months ago

kostis commented 11 months ago

Upgrade to use the newly released learnlib-0.17.0. With the exception of one file (out of 140), most of the changes are OK, I thnk.

Help is needed (@fhowar @mtf90) to properly adapt the code of AbstractToolWithRandomWalk.java. To simplify things, changes to this file are separated from the rest and appear in the second to last commit (the one titled Temporary fix to AbstractToolWithRandomWalk)

mtf90 commented 11 months ago

Since you have adapted to slf4j in the remaining code, i think the most reasonable approach would be to return a Set<Marker>. However, given that you likely want to use the slf4j-jdk14 backend (since the OPTION_LOGGING_LEVEL parser returns a native j.u.l.Level object) you may as well remove/ignore this property completely, because I don't think j.u.l. logging supports the concept of markers anyway.