search

LearnLinuxTV / personal_ansible_desktop_configs

317 stars 98 forks source link

Replace short module names with FQCN #5

Closed alexs77 closed 2 years ago

alexs77 commented 2 years ago

Instead of using eg copy, use ansible.builtin.copy to avoid possible clashes in names.

I went through all of the Ansible YAML files and replaced the short names. This is the result of running the following shell script:

find . -type f -name "*.yml" -exec perl -pi -e 's, (pacman|timezone|locale_gen|dconf|flatpak|snap|flatpak_remote):, community.general.$1:,' '{}' '+'

find . -type f -name "*.yml" -exec perl -pi -e 's, (file|apt|service|pip|lineinfile|copy|apt_repository|apt|cron|command|template|group|user|git|import_tasks|apt_key|get_url|unarchive|stat|blockinfile|debconf|include_tasks|include_vars|package|replace):, ansible.builtin.$1:,' '{}' '+'
alexs77 commented 2 years ago

This fixes #5 .

LearnLinuxTV commented 2 years ago

One potential issue I see here, is that in my experience, some distributions do well with FQCN while it causes Ansible runs to fail on others. I haven't had a chance to dive in extremely deep, but it seems to be due to some distros (for example, older LTS releases) that haven't yet moved to newer Ansible versions.

Which distro(s) did you try the change on? Thanks!

LearnLinuxTV commented 2 years ago

Thank you for taking the time to write this in. However, I don't accept pull requests or issues on this particular repository - reason being, it's provided as reference for a video and isn't actually useful on its own. I have to make sure it's the same as in the video. But maybe this might be a consideration for the future though!