Open gulyx opened 8 years ago
We are working on it, actually there is a working version with an issue that we will solve asap.
@acalabro can u clarify?
The score is sent to the sim, Sim shows only one parameter in one case and in another case it remains stopped waiting for message/something. It's probably a synchronization issue
The "Sim shows only one parameter" issue should be fixed by #586. For the other case (simulation hanging) it seems to be an issue in the way score messages are sent/received on additional runs. I already sent some info to @acalabro and we are looking into it
@acalabro, after your last PR (#589), I still identified some issues. After the first session is completed normally, the next sessions complete correctly but the score event is also sent to the probes of the finished sessions (several times apparently ?), causing errors.
It does not seems to send these events to unfinished session probes, so this does not appear to be a blocking issue however.
@tomjorquera mmh, the scores will be sent on the same channel "scoresUpdateResponses" , so also the other probe should be able to read the score updated that can be distinguished from the previous cause it has a different userID field value. However, I am actually running a test with two local probes listening on the same channel and let you know in a minute
@tomjorquera any news from your side?
@tomjorquera please consider the warning note i put at the end of this slice I described on the wiki http://wiki.learnpad.eu/LearnPAdWiki/bin/view/WP10/Y3%2DSliceB
Regarding @acalabro last comment, PR #591 should fix the issue.
Regarding your own note @gulyx, looking into it...
@gulyx, regarding the issue mentioned in the wiki, if I understand correctly it seems to me that the last PR should have fixed that
@gulyx the issue seems to be solved by #591 and #590
@acalabro @tomjorquera fine merged also PR #590. however i noticed that :
Is there something we can do in these directions?
By the end of the day I will circulate some slides with a proposal. The idea is tu use also those slides for Slice C presentation
@gulyx
@acalabro @tomjorquera any news on that?
I don't know if you prefer to leave the score as they are and explain their meaning during the demonstration using slides I circulated yesterday or if you prefer to update also the field in the simulator panel. What is your opinion @gulyx , @tomjorquera ?
@acalabro @tomjorquera better label names and units will help for sure
@gulyx I just sent a mail with a link to gdoc where we can decide possible names. I created a gdoc in order to be able to share also with person that are not on github.
@gulyx @tomjorquera here my proposal:
Task Score ---> Task Score
Session Score ---> Session Score
Absolute Session Score ---> Best score reachable for this session
% Coverage ---> % of modelset discovered
Business Process Score ---> Max scores obtained for this modelset
Relative Business Process Score ---> Best score reachable for this modelset
Global Score ---> Max scores obtained on all modelsets
Absolute global Score ---> Best score reachable for all modelsets
@acalabro they look fine with me. what about you @tomjorquera ?
@gulyx @tomjorquera another proposal
Task Score ---> Task Score
Session Score ---> Session Score
Absolute Session Score ---> Top score of the session
% Coverage ---> Your % of modelset exploration
Business Process Score ---> Your best scores for the modelset
Relative Business Process Score ---> Your top reachable best score for the modelset
Global Score ---> Your total score on the all the explored modelsets
Absolute global Score ---> Your top reachable best score for all the explored modelset
@acalabro @tomjorquera fine with me. let me know when these will be included in the UI
PR #602 changes scores descs according to this last proposal
@acalabro @tomjorquera in marsala we agreed to include in the score-list presented in the UI at the end of a simulation session also the results of the evaluation from the MON part. which is the status of this activity?