search

LearnProgramming / percival

An IRC bot designed to help the LPMCers track quotes, log channels, and all sorts of things
22 stars 8 forks source link

Connect four #23

Open colwem opened 12 years ago

colwem commented 12 years ago

A connect four playing AI.

travisbot commented 12 years ago

This pull request fails (merged 9a87ec10 into b33d958d).

colwem commented 12 years ago

Joe Fredette

I want to send this as a seperate PR but it is based directly upon PR 13. How am I really supposed to do this or is this correct?

jfredett commented 12 years ago

If you rebase now, those extra commits should go away.

Generally I just wait for the first to get merged, there's not really a good way to specify dependencies

travisbot commented 12 years ago

This pull request passes (merged 70e63a5f into 2e5359f5).

jfredett commented 12 years ago

I'll take a better look at this later. It looks neat, but could stand some refactoring to separate the internal game logic from the rendering of messages to the user, and needs some general idiomatic cleaning (parens around method definitions, mostly)