search

LearnStack / LSNewsletterInvite

A simple newsletter invite popup that works with MailChimp to help you get more newsletter signups.
http://learnstack.com/
MIT License
25 stars 6 forks source link

MailChimp API returns success for failure #8

Open dreese opened 11 years ago

dreese commented 11 years ago

If I don't set any MailChimp values in settings or info.plist, then try to submit a signup, the MC API returns a "success" value with an error message and code embedded inside it. I would have thought it would return "failure".

This might be a ChimpKit issue.

jkhowland commented 11 years ago

This is a good find. I may have to fix it on the client side, because MailChimp doesn't seem to return failure for a bad API key.

dreese commented 11 years ago

That's really odd. Maybe we need to submit a bug report to mailchimp? Or is it chimpkit that needs fixing?

On Mon, Aug 26, 2013 at 8:44 AM, Joshua Howland notifications@github.com wrote:

This is a good find. I may have to fix it on the client side, because MailChimp doesn't seem to return failure for a bad API key.

Reply to this email directly or view it on GitHub: https://github.com/LearnStack/LSNewsletterInvite/issues/8#issuecomment-23267119

jkhowland commented 10 years ago

Seems to me that we should submit this bug to Mailchimp, but we should fix it so there isn't a crash.

dreese commented 10 years ago

I haven't seen a crash, though there may be one. It's just that a clear failure is still triggering the "success" callback rather than the "fail" callback.