search

LearnToDiscover / sandpaper

L2D's fork of {sandpaper}
https://learntodiscover.github.io/sandpaper/
Other
0 stars 1 forks source link

Include level 3 headings in sidebar #76

Closed milanmlft closed 5 months ago

milanmlft commented 5 months ago

Adds level 3 subheadings to the navigation sidebar and allows clicking them to scroll to the corresponding section.

To test locally, run

remotes::install_github("LearnToDiscover/sandpaper@milanmlft/sidebar-subheadings")
sandpaper::build_lesson("/path/to/lesson/")

in R where "/path/to/lesson" is the path to any lesson directory you have locally (preferably one with level 3 headings to see what changed :slightly_smiling_face:), Basic_Python is probably a good test case

Fixes #69

milanmlft commented 5 months ago

is there a way that these subsections are collapsible as they can overwhelm the interface for people may be. What do you think?

I think this might be possible but would require significantly more work. So maybe I'd suggest creating a new issue for that and get this PR merged in?

sabaferdous12 commented 5 months ago

@milan, do I still need to create a new issue for this extension and approve this for a merge as it is?

milanmlft commented 5 months ago

@milan, do I still need to create a new issue for this extension and approve this for a merge as it is?

If you want this as a future feature, then yes, you should create a new issue.