search

LearnersBlock / learners-block

Provide educational resources, websites and popular EdTech (Kolibri, Moodle) offline.
https://learnersblock.org
GNU General Public License v3.0
12 stars 1 forks source link

Integrate ePub reader into File Manager #130

Closed maggie44 closed 3 years ago

maggie44 commented 3 years ago

When clicking a .epub file in file manager (as non-admin) instead of downloading the file, it will redirect to an epub reader stored at /epub_reader. That epub_reader receives the URL to open from ?url=http://url-to-the-filemanager-file.

Remote upload has been disabled as it was a little temperamental, and not really a necessary feature for now.

maggie44 commented 3 years ago

Had a quick look at the changes you made in this PR, and you're actually introducing/changing code within the file-manager/src directory which is a bit problematic.

I initially introduced the new extensions and build logic to avoid altering any of the source code from IFM, but of course those only allow a rather limited number of changes. If we start making actual changes the code base inside the src directly, we're making it incredibly difficult to merge any upstream fixes and updates back into the fork.

Therefore checking: is this really the way you want to go?

It’s a fairly minor change, and to a part that isn’t affected by anything in the pipeline for IFM. I proposed the same change upstream for an ePub support app, but doubt it will be merged as it’s such a specific thing. I’m open to alternative ideas if you have any, otherwise think we will just have to handle any merge conflict as and when it comes. It’s not a particularly frequently maintained app so doubt there will be many.