search

LearnersBlock / learners-block

Provide educational resources, websites and popular EdTech (Kolibri, Moodle) offline.
https://learnersblock.org
GNU General Public License v3.0
12 stars 1 forks source link

Remove repeated JSON language entries #58

Closed maggie44 closed 3 years ago

maggie44 commented 3 years ago

Can we use the 'general' section more of the JSON language file. For example, at the moment the word 'close' is being translated 8 times for each language, would be easier for translation to have it done once in the general section. Same for other repetitive strings.

https://github.com/LearnersBlock/learners-block/blob/22897e1b06e31570aaf0f77fcc61948a7e3e32f1/frontend/apps/interface/src/lang/en.json#L161

maggie44 commented 3 years ago

Submit the change to the l10n_master branch though, and will merge it later (due to some Weblate issues).

maximilianoertel commented 3 years ago

I can do that, no problem.

Just for my curiosity: why did we need a l10n_master branch? Does Weblate do something weird?

maggie44 commented 3 years ago

Forget the last message, managed to bring the two branches in line so can make changes directly to Master.

l10n_master is created automatically by Weblate when changes are made in the Weblate interface, so that they are not pushed straight to Master.