LearnersGuild / echo

learning management system
MIT License
3 stars 31 forks source link

Modifies ProjectList to display most recent projects regardless of state #1044

Closed sdweber422 closed 7 years ago

sdweber422 commented 7 years ago

Fixes #914

Overview

The ProjectList component did not display projects (if they existed) if cycle state was 'GOAL_SELECTION'. The ProjectList container retrieved the the projects for the current cycle, which contained no projects when cycle state was 'GOAL_SELECTION', which in turn, led to a message of 'No projects found'. The user would then have to click on the 'Load More...' button to display the most current projects. This was due to the dispatch to the findProjects action which would initially return an empty array when cycle was in 'GOAL_SELECTION' state.

This was changed to a dispatch calling the findProjectsForCycle action, which returns only the projects for the specified cycle provided to it. If no cycle was provided, it returns the projects from the most recent cycle. The message 'No projects found' now occurs only if no projects exist in the database.

Due to the changes in the way projects are retrieved, the findProject action now returns all projects in the database. Also, two obsolete server actions were removed: getNextCycleIfExists and getPrevCycleIfExists. This is because findProjectsForCycle only needs the cycleNumber, and if there is not one provided, will return the projects in the most current cycle that has projects.

Data Model / DB Schema Changes

None.

Environment / Configuration Changes

None.

Notes

None.