search

LearnersGuild / echo

learning management system
MIT License
3 stars 31 forks source link

Abort `userCreated` job handling if user already has membership in chapter #1090

Closed heyheyjp closed 6 years ago

heyheyjp commented 6 years ago

Instead of upserting a member when handling new user creation, just abort. This would have prevented an instance of data corruption that occurred this morning when many users' phases were reset to 1 following the queuing of a bunch of new userCreated jobs that shouldn't have been queued. The jobs were triggered by a migration of user role data in idm.

heyheyjp commented 6 years ago

Resolved in https://github.com/LearnersGuild/echo/pull/1081.