search

LearnersGuild / echo

learning management system
MIT License
3 stars 31 forks source link

Fixes lots of linting warnings #1095

Closed lumodon closed 6 years ago

lumodon commented 6 years ago

Fixes #1082

Overview

Problem with linter taking too long - requiring optimizations.
This PR attempts to optimize by reducing the 420 warnings down to zero with lint line ignores and a few code corrections

The large majority of linting warnings comes from import/named due to eslint not recognizing autoLoader's import pipeline
could not solve this, so disabled the rule globally for now until a solution can be found.

Data Model / DB Schema Changes

None

Environment / Configuration Changes

package.json
  xo
    "rules": {
      "import/named": 0

import/named used to be 1

(any updates to the configuration files?)

Notes

  1. Some linting fixes use ignores, others fixed by changing the code itself.
  2. Concern: disabling import/named globally in the xo config (package.json) seems a little overkill - how can we teach eslint about files being imported through/due to autoLoader?
  3. Disabling the 'FIXME' comments - will this lead to ignoring them or will our team still get around to them?
heyheyjp commented 6 years ago

@lumodon @je-lopez: something went wrong here. Most of these commits shouldn't be in this PR.