search

LearnersGuild / echo

learning management system
MIT License
3 stars 31 forks source link

1082 - Linting Performance #1101

Open lumodon opened 6 years ago

lumodon commented 6 years ago

Fixes #1082

Overview

Reduces over 400 linting warnings down to 12 linting warnings
Most coming from 'import/named' and 'prefer-default-export'
This changes imports and exports to be static
Also removes autoloader and replaces with static list of imports and exports for entire folder structure

Data Model / DB Schema Changes

N/A

Environment / Configuration Changes

Removes 'keymirror' and 'autoloader' from package.json

Notes

  1. Last few linting warnings couldn't be fixed to due to be used/imported dynamically
  2. lots of files still mix and match import and require.
  3. Some files have been eslint-disabled, particularly ones involving comments with "TODO" or "NOTE" - if planning on removing those comments in future will have to search them instead of relying on linter to find them.