search

LearnersGuild / echo

learning management system
MIT License
3 stars 31 forks source link

cannot clear a learner's phase successfully #1105

Closed jeffreywescott closed 6 years ago

jeffreywescott commented 6 years ago

Stephan Weber has left the Guild. I tried to clear his Phase by setting it to "No Phase" in echo, but it doesn't save -- it just reverts to the original value (in this case, 5).

https://app.asana.com/0/139326150873509/440170766072322

jeffreywescott commented 6 years ago

Maybe it's just not deployed yet, but ... still not working for me, FWIW.

heyheyjp commented 6 years ago

Yeah, hasn't deployed yet. Some weirdness with a timezone-related thing causing the build to fail. Looking into it now.

jeffreywescott commented 6 years ago

timezones

jeffreywescott commented 6 years ago

@prattsj FWIW, I just retried this this morning and it still doesn't work.

heyheyjp commented 6 years ago

Yeah, that's why I reopened. Fixes for the server action handling a null phase and for the awkward time-related test bug are out, and the build is okay, but it revealed another issue with the front-end having to do with graphql and the version we've been using stripping properties w/ null values from queries. I'm upgrading all of our graphql-related deps (some of which have breaking changes), and it's almost wrapped up now. I'm also adding the missing test for setting the phase to null.

https://github.com/graphql/graphql-js/issues/133 https://github.com/facebook/graphql/pull/83