Thinky.io conventions are adhered to

LearnersGuild / echo

learning management system

MIT License

3 stars 31 forks source link

Thinky.io conventions are adhered to #937

Open jeffreywescott opened 7 years ago

jeffreywescott commented 7 years ago

From ch1546

https://app.asana.com/0/132812069238646/287114355261186

Here's what I remember:

Either we need to cede the responsibility of creating tables to Thinky, or we need to create the tables using the same conventions Thinky expects:
- snake_case table names rather than camelCase
- indexes named in expected ways so that many-to-many joins via Thinky work

jeffreywescott commented 7 years ago

[Comment from Clubhouse user @prattsj:] @jeffreywescott: Finding this at the top, but I think it'll be easier to tackle this last. i also believe it to be the lowest priority arch/refactor item in the backlog. Mind reconsidering or at least talking it out?

jeffreywescott commented 7 years ago

[Comment from Clubhouse user @jeffreywescott:] I'm happy to reprioritize, though I'm pretty sure that this needs to happen before we redesign the stats data model, because many-to-many relationships won't work without doing this first.

jeffreywescott commented 7 years ago

[Comment from Clubhouse user @prattsj:] Makes sense. Seems fine/good to go before the data model changes, but I still think these two - together, the "Refactor Data Model" epic - should be the very last to happen, being the only two to require a migration.

Proposed order of epics:

Reorganize (core biz logic) code
Refactor stats code
Refactor data model

jeffreywescott commented 7 years ago

[Comment from Clubhouse user @jeffreywescott:] @prattsj: move to P4 GH?