search

LearnersGuild / idm

identity management service
MIT License
2 stars 24 forks source link

Centralize selection of a user's profile image URL #111

Closed heyheyjp closed 8 years ago

heyheyjp commented 8 years ago

Makes an attempt to auto-parse a user's profile image URL and attaches as profileUrl prop. We now have at least 2 different places where user avatars need to be displayed: echo chat and in parts of the retrospective survey form. Ideally, we've only got code written once to determine the URL for a profile image to be displayed. Seems to make the most sense that this logic lives here in the idm service.

jeffreywescott commented 8 years ago

Is this necessary? If we're using github profile images, can't we just use:

https://github.com/<handle>.png?s=<size>

heyheyjp commented 8 years ago

I'd prefer to not have duplicate profile image URL parsing/construction logic all over the repos...