Add an "active" flag to users table (and respect it)

LearnersGuild / idm

identity management service

MIT License

2 stars 24 forks source link

Add an "active" flag to users table (and respect it) #121

Closed bundacia closed 8 years ago

bundacia commented 8 years ago

We could make slightly nicer error messages for the user here, but it would be a lot more work and would only help us in some (for now) very edgy edge cases, so I decided it wasn't worth it at this time. So the user will see the same errors when they have no account as when they have a deactivated account:

Authentication failed. Are you sure you have an active account?

Fixes #115 Fixes #116 Fixes #117

jeffreywescott commented 8 years ago

If we update the idm-jwt-auth module to respect the active flag, we'll need to update the version of it that we're using everywhere:

echo-chat (packages/rocketchat-lg-sso/package.js)
game (package.json)
graphiql (package.json)
idm (package.json)

bundacia commented 8 years ago

@jeffreywescott: here's the idm-jwt-auth PR: https://github.com/LearnersGuild/idm-jwt-auth/pull/5

bundacia commented 8 years ago

All systems are using the new version except echo-chat. Didn't want to deploy that during business hours. PR waiting for deploy here: https://github.com/LearnersGuild/echo-chat/pull/57