search

LearnersGuild / idm

identity management service
MIT License
2 stars 24 forks source link

better timezone handling #129

Closed jeffreywescott closed 8 years ago

jeffreywescott commented 8 years ago

Fixes #58. Fixes #94. Fixes #104.

jeffreywescott commented 8 years ago

@prattsj / @bundacia -- would be great to get this reviewed (and hopefully merged if it looks okay) before I go on vacation. This is a v1 "must have".

bundacia commented 8 years ago

In chrome and safari on OSX (desktop) I only get one choice for timezone, so I can't change it.

identity_management
jeffreywescott commented 8 years ago

@bundacia, it's not a drop-down, it's an auto-complete. There are something like 568 timezones in the IANA database, so a drop-down doesn't really make sense. If you clear out the field and start typing "Amer" or "US", do you see more?

It's definitely not the best UX, but 99% of the time, it should pre-populate people's correct timezone, so hopefully it's "good enough". /cc @tannerwelsh

tannerwelsh commented 8 years ago

Definitely not ideal, but better than what was there.

Would it be simple enough to "guess" the timezone and pre-populate the choice using something like Date#getTimezoneOffset?

The main UX issue I see here is that not many people know their exact timezone code, or even how to begin searching it. City? Region? US / America / United States? So giving a "best guess example" would at least point them in the right direction (i.e. no, I'm not America/Los_Angeles, but maybe they have America/Denver...)

jeffreywescott commented 8 years ago

@tannerwelsh it DOES guess and autopopulate the field using the moment-timezone library.

bundacia commented 8 years ago

@jeffreywescott ok, I see. I was clicking on the down arrow. Even after reading your explanation here it took me a few tries to get this right. I eventually got it. So I guess this is an improvement since with what's live I can't change my timezone at all (and I guess it crashes on safari?). UX is just a little quirky.

jeffreywescott commented 8 years ago

Yeah -- it's definitely an improvement. Do you think it would help if, when a person focused the field it cleared it out? That seems overly aggressive to me, but maybe it's better?

bundacia commented 8 years ago

Nah, I agree that that would be overly aggressive.

On Tue, Aug 23, 2016 at 11:46 AM Jeffrey Wescott notifications@github.com wrote:

Yeah -- it's definitely an improvement. Do you think it would help if, when a person focused the field it cleared it out? That seems overly aggressive to me, but maybe it's better?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/LearnersGuild/idm/pull/129#issuecomment-241778406, or mute the thread https://github.com/notifications/unsubscribe-auth/AALlA-gIm_U_Q5dWINh-vO6OyYtEYdSrks5qixXGgaJpZM4JoCGc .

heyheyjp commented 8 years ago

One blocking issue that'll be easily fixed. Otherwise LGTM.