search

LearnersGuild / idm

identity management service
MIT License
2 stars 24 forks source link

fix sign-up bug related to redux-form / react-toolbox bugs and incompatibilities #138

Closed jeffreywescott closed 8 years ago

jeffreywescott commented 8 years ago

Fixes #136.

This PR updates several of the third-party libraries that IDM depends on. Most of the code changes are related to making the code work on these newer versions of the libraries.

In addition:

See also: #137

jeffreywescott commented 8 years ago

Wow, @bundacia, that's super weird, especially in light of commit https://github.com/LearnersGuild/idm/pull/138/commits/3cf0313913f4ba321295a3c949d97a5973e052fc

I'll investigate. Thanks for testing it.

jeffreywescott commented 8 years ago

@bundacia I just tested again and am not getting that error. I was when I originally started to fix this issue, thus that aforementioned commit. Sorry to ask such a stupid question, but are you SURE you're on the jw/136-sign-up-bug branch and not on master?

I'm going to blow away my repo and re-pull and re-test, just to verify.

jeffreywescott commented 8 years ago

@bundacia -- also wondering if you have an up-to-date .env.development with APP_BASE_URL set?

jeffreywescott commented 8 years ago

@bundacia after blowing away my IDM repo, recreating my .env.development, and re-testing this branch, I still cannot reproduce your error. :-(

heyheyjp commented 8 years ago

@bundacia: this is almost certainly a config/env variable issue. Be sure to check your local .env.* files and compare them to src/config to make there's a value in .env.* for anything expected to be found in process.env.

jeffreywescott commented 8 years ago

Yeah, that domProps stuff is annoying, but it was better than rewriting everything to work with redux-form 6.x, which has a different solution for it, but would require redoing the whole form using their Field component. :-(

Thanks for the review!