search

LearnersGuild / idm

identity management service
MIT License
2 stars 24 forks source link

adding getUsersByHandles #85

Closed bundacia closed 8 years ago

bundacia commented 8 years ago

needed for https://github.com/LearnersGuild/game/issues/109

I'm not doing anything fancy here, just copying an existing endpoint and changing it to fetch by handle instead of id. Ideally there's be tests and stuff but I'm making a conscious choice here to skip that for two reasons:

  1. since there are no tests at all for the API endpoints here I'd have to pay some startup cost to get all that going and I don't think now is the time.
  2. the change is small and almost an exact copy of existing code, so the risk is small.
bundacia commented 8 years ago

blocks https://github.com/LearnersGuild/game/pull/121

jeffreywescott commented 8 years ago

Looks solid.