jeffreywescott
commented
8 years ago @prattsj:
- I agree that the pre-requisite to sign up for GitHub is annoying, which is why this PR exists: https://github.com/LearnersGuild/rocketchat-lg-sso/pull/18 Ideally, we want people to get a sign-up page rather than a sign-in page for their first visit. That will help to reduce at least some of the confusion, because there's a blurb at the top of that page that says:
We'll need your GitHub account information, so the first step is to authenticate using GitHub. If you haven't yet created a GitHub account, you should do that now.
I'm open to changing the language to make things clearer on the sign-in page, too. What do you suggest?
- Most learners will already have a GitHub account before they ever hit our sign-up page. For one thing, they were in the enrollment games that will require it. And I think in whatever email we send out to tell them to create their LG IDM accounts, we should warn them to create a GitHub account first. The blurb at the top of the sign-up page does so, but perhaps not clearly enough.
I can't think of a way to get around the lack of redirecting back to IDM during the corner-case that the user creates a GH account as part of the initial sign-up flow. Any ideas?
[Extracted from a comment by @prattsj on #88.]
@jeffreywescott: I still find parts of the sign up flow confusing. Apologies if these tensions are intended to be addressed in another issue/PR. Please point me in the right direction if so...
Issue 1 What do we mean here by "sign up"? There seem to be 2 different kinds of signing up in play:
When I see this...
...as someone totally new...
...followed by...
...gives me the impression that by clicking the sign-up link, I'll be directed to set up a github account.
Instead, I'm directed to enter an invitation code. This is confusing.
Issue 2 I wasn't redirected to the idm service after setting up a brand new github account because of a requirement that email addresses for new accounts be verified before the user is allowed to authorize an OAuth application.
But it isn't totally clear to me that this is unintended behavior by the original issue description. Could use some clarification on what "signing up" means.
Other than that...had some comments above re: the flow of data through the app + redux and where it's most appropriate to interface directly with the dispatcher. Nothing urgent, but worth discussing.
Code looks pretty good otherwise!