LearnersGuild / learning-os

The Learning Operating System of Learners Guild. Our applied game and player support.
0 stars 1 forks source link

Sb/teams #231

Closed shereefb closed 8 years ago

shereefb commented 8 years ago

Closes #126 Closes #206 Closes #55 Closes #227 Closes #102 Addresses #13 Closes #232 from tw Closes #233 from tw

tannerwelsh commented 8 years ago

Overall feedback:

I like the direction this is going. It's a massive chunk, and useful to see all in one piece.

The Team Formation process is complex. I like how it tries to balance many pieces, but I worry that the algorithm is too dense. Took me two readings to grok it. Not necessarily a bad thing, but if it can be simplified and still achieve the core outcomes, it should.

Maybe an alternative would be to have the "human language" version of the team formation algorithm alongside:

  1. Vote on goals
  2. Let least experienced player who has fewest goals picked, pick the goal
  3. Form teams based on whoever else voted for that goal and has roughly the same experience
  4. Choose a team lead from a more advanced cohort
jeffreywescott commented 8 years ago

Wow. This is a HUGE volume of work. Kudos, @shereefb. I added some comments / questions as I read through the changes, most of which (hopefully) will serve as "bug reports". The others are just questions, I think. But I'm keen to get this all squared away, as it will drive lots of the software epics.

tannerwelsh commented 8 years ago

@shereefb just fixed the merge conflicts. Should be ready to merge.

tannerwelsh commented 8 years ago

:tada: :tada: :tada: :tada: :tada: :tada: :tada: