search

LearningProcesss / boardgamegeekjsclient

Typescript written API wrapper for Boardgamegeek XML2 API
MIT License
18 stars 6 forks source link

Support for 'poll-summary' when using 'thing' #59

Open ZinkNotTheMetal opened 1 month ago

ZinkNotTheMetal commented 1 month ago

It looks like BGG added a new property in the XML API named 'poll-summary' with this the thing api no longer works properly and is throwing an error when binding to the BggThing object.

darekkay commented 1 month ago

I would argue that a new (unknown) property shouldn't break the existing API. I assume that LearningProcesss agrees, as they have created this request 2 years ago: https://github.com/pichillilorenzo/jackson-js/issues/41

ericpoulinnz commented 3 weeks ago

That's a really frustrating underlying issue.

@LearningProcesss any chance this is a quick fix for this instance?

darekkay commented 2 weeks ago

I've posted the technical solution to ignoring unknown properties in the jackson-js repository. I have also fixed the issue in my fork, but only for this particular problem (BggThingDto object). If @LearningProcesss agrees with the proposal, I can implement it for all DTOs and raise a PR.

Until then, I am using a workaround with my own fork as an npm dependency:

{
  "boardgamegeekclient": "git+https://github.com/darekkay/boardgamegeekjsclient.git#2b62d8927fb183af5883dbf683e700d5b128107f"
}