LearningTypeScript / projects

Hands-on real world projects that will help you exercise your knowledge of TypeScript.
https://learningtypescript.com/projects
226 stars 151 forks source link

docs: fix missing steps in Vacation Planning project #275

Closed vimode closed 11 months ago

vimode commented 11 months ago

PR Checklist

Overview

After submitting my previous issue & PR I read this in the template

If this report is for a small typo you're sure is a mistake, feel free to instead send a pull request directly.

So submitting a PR directly instead. 😄


In the Project Vacation Planning the keys mentioned in the Steps are incorrect.

Lighthouses: It was first lit in <lit> and is <feet> feet high.

<feet> should be <height>

Rivers: It flows for <length> miles and is <deep> feet deep at its deepest.

<deep> should be <depth>

I also noticed some entries in landmarks.json do not have all the keys required for each landmark but I guess that OK as they do affect the passing of the tests.