Re-pin php5 compatible versions for dependencies in vendor.

Learnosity / learnosity-sdk-php

Learnosity SDK for PHP

Apache License 2.0

10 stars 10 forks source link

Re-pin php5 compatible versions for dependencies in vendor. #28

Closed ekcolysp closed 6 years ago

ekcolysp commented 6 years ago

The previous commit ended up with php7 packages due to us running composer update in a php7 environment. This can potentially break the php5.6 || php7 compatibility.

This PR pins the platform to php5.6, so that we can get dependent packages for php5.6.

ttton commented 6 years ago

Based on our discussions, we're not going to merge this change, since it will prevent anyone who is already running a PHP 7 environment from automatically getting the benefits of PHP 7-only features in the sub-packages. If any users of the SDK need their codebases to explicitly support PHP 5 environments, they can specify the platform in their own composer.json file.