search

Learnosity / learnosity-sdk-php

Learnosity SDK for PHP
Apache License 2.0
10 stars 10 forks source link

[FEATURE] Add release script #34

Closed kevinmcdonnell closed 6 years ago

shtrom commented 6 years ago

Sorry @kevinmcdonnell , didn't get a chance to get to it yet. From a quick glance it looks good.

It might be beneficial to run shellcheck on it, as it flags a lot of sub-optimal patterns (I haven't seen any, but it will be more exhaustive than me). It's in Homebrew.

It would be good to add a shebang, and make the script executable, too, so the Makefile doesn't have to specificy it needs to run through bash.

I'll review in more details soon.

kevinmcdonnell commented 6 years ago

@shtrom ready for another look and test

kevinmcdonnell commented 6 years ago

@shtrom would you like to add these changes? not sure it's efficient for me to do so..

kevinmcdonnell commented 6 years ago

shellcheck said to use double backslash

shtrom commented 6 years ago

If shellcheck says so... (I never ran into that one before 😀 ). I'll rebase and add the changes on my test branch 👍