search

Learnosity / learnosity-sdk-php

Learnosity SDK for PHP
Apache License 2.0
10 stars 10 forks source link

Feature/changelog #36

Closed shtrom closed 6 years ago

shtrom commented 6 years ago

@kevinmcdonnell Small changes to the release script to allow us to maintain a ChangeLog. I think we need to go down this [0] way, as it may be more pallatable than commit logs. Care to have a look?

I'll func by cutting a new release afterwards.

[0] https://keepachangelog.com/en/1.0.0/

kevinmcdonnell commented 6 years ago

Do we need a changelog and release notes in the tag?

I fear you will find something new to add to the release script every time we use it. We should keep it simple

shtrom commented 6 years ago

Not sure. I didn't want to remove the commits without discussion, but I think the ChangeLog is more palatable, as the tag message ends up in the Log for the release in GitHub.

shtrom commented 6 years ago

@kevinmcdonnell how would you suggest we progress on this? I can remove the commit log from the log message, as I think it's redundant and less informative for an external user than the ChangeLog is.

kevinmcdonnell commented 6 years ago

looks good