Bug/dataapi request packet

Learnosity / learnosity-sdk-php

Learnosity SDK for PHP

Apache License 2.0

10 stars 10 forks source link

Bug/dataapi request packet #37

Closed shtrom closed 5 years ago

shtrom commented 5 years ago

Checklist

[ ] Feature
[X] Bug
[X] ChangeLog.md updated
[ ] Tests added
[X] All testsuite passes
[X] make dist completed successfully

shtrom commented 5 years ago

@flakeparadigm this should fix the test issue that ran into with your PR; please rebase/merge with this, and all should be fine.

shtrom commented 5 years ago

The FIXME is for backward compatibility with existing users. I guess a better way would be to add a warning saying that it should be an array.

flakeparadigm commented 5 years ago

A warning might be useful if you have a sec to add it in. I'm not sure that everyone using this will have the time to look through the code changes of every release they update to in order to see the FIXME.

shtrom commented 5 years ago

@flakeparadigm Ready for CR.

shtrom commented 5 years ago

Hum, some CBF linting changes snuck in, but they can't hurt.

shtrom commented 5 years ago

Agreed, no need for a release just yet.