Learnosity / learnosity-sdk-python

Learnosity SDK for Python
Apache License 2.0
7 stars 10 forks source link

LRN-34037 Option 1: Containerise within Makefile #57

Closed david-scarratt-lrn closed 2 years ago

david-scarratt-lrn commented 2 years ago

Summary

Add the ability to run make targets in a Python container. The containerising happens within the single Makefile in the directory.

Pros

Cons

Checklist

shtrom commented 2 years ago

The code looks good, but we might need to update the documentation about expected dependencies (docker) and flow. Note that there is a separate documentation overhaul effort in #56, and one thing that is specifically left out for now is the CONTRIBUTING.md, where I think this information could go.

alangarf commented 2 years ago

This looks great! Well done.