Closed david-scarratt-lrn closed 2 years ago
The code looks good, but we might need to update the documentation about expected dependencies (docker) and flow. Note that there is a separate documentation overhaul effort in #56, and one thing that is specifically left out for now is the CONTRIBUTING.md
, where I think this information could go.
This looks great! Well done.
Summary
Add the ability to run make targets in a Python container. The containerising happens within the single Makefile in the directory.
Pros
Cons
clean
)Checklist
[x] Feature
[ ] Bug
[ ] Security
[ ] Documentation
[ ] ChangeLog.md updated
[ ] Tests added
[ ] All testsuites passed
[ ]
make dist
completed successfully