Learus / react-material-ui-carousel

A Generic carousel UI component for React using Material UI.
MIT License
550 stars 219 forks source link

`@material-ui/core@4` support #212

Open neo-andrew-moss opened 1 year ago

neo-andrew-moss commented 1 year ago

Hi @Learus!

First off, thanks for a great carousel implementation. Carousels are always a bit of a nightmare, but this one is amazing.

Anyway, I am using react-material-ui-carousel@2 as my app does not yet support "@mui/material". However, the peerDependencies of react-material-ui-carousel@2 are pointing towards "@material-ui/core": "^4.11.3", which doesn't work for me as I am using "@material-ui/core": "4.11.2",. Resultingly, I have to install this library with --force or --legacy-peer-deps, which is sub-optimal.

What do you think about another v2 release with slightly more relaxed peers? Im not sure what this would look like semver wise but I created a good implementation that could be used for this.

I forked this lib and created react-material-ui-carousel-alt, which is a refactor of react-material-ui-carousel@2 with all the updates of react-material-ui-carousel@3 but with @material-ui/core@4 instead of "@mui/material". The peerDependencies of react-material-ui-carousel-alt are a little more flexible.

Let me know what you think!