User Deprecated Symfony 4.0

[allfreelancers]

User Deprecated: Implementing "Symfony\Component\HttpKernel\DataCollector\DataCollectorInterface" without the "reset()" method is deprecated since Symfony 3.4 and will be unsupported in 4.0 for class "Lsw\MemcacheBundle\DataCollector\MemcacheDataCollector".

[mevdschee]

Good find, thank you. What do you propose? Can you do a PR?

[allfreelancers]

@mevdschee What does PR mean?

[mevdschee]

@allfreelancers ... sorry about the acronym.. I meant a Pull Request.

[allfreelancers]

@mevdschee ok, a little later I will do

[GabrielAnca]

Hi @allfreelancers. We would be very happy if you want to contribute about this issue. You can use these two pull requests as reference, they fixed the same issue in other of our bundles:

• https://github.com/LeaseWeb/LswApiCallerBundle/pull/36
• https://github.com/LeaseWeb/LswApiCallerBundle/pull/37

Best regards

[allfreelancers]

@GabrielAnca, in Lsw\MemcacheBundle\DataCollector\MemcacheDataCollector we can add this?

public function reset()
{
  $this->data = [];
}

[GabrielAnca]

Hi @allfreelancers, if you do that, it will most likely remove the warnings.

Please use array() instead of [] to keep backwards compatibility :)

[tobias-93]

For anyone looking for a Symfony 4 compatible version of this bundle: I have forked the bundle and applied the patches necessary for Symfony 4 here: https://github.com/Kick-In/LswMemcacheBundle. Use "kick-in/memcache-bundle": "~v3.0" as composer constraint.