Closed arunvarghe closed 3 weeks ago
It also appears that you haven't enabled the git hooks :-). Run the following:
pnpm i
The current commit message also needs to be changed to adhere to conventional commits. In this case it should be something like feat: implement dedicated_server control panels datasource
Looks good! Just one thing about the commits, they should be in present tense as it's easier to read. This will become important for the auto generated changelog & release notes in the future.
So feat: fixed comments about test cases and documentation
should be feat: fix comments about test cases and documentation
In commit messages feat
should only be used for introducing new features to the code base. So it should be chore(docs): fix comments about test cases and documentation
or docs: fix comments about test cases and documentation
.
I recommend taking 10 minutes to go through the conventional commits summary. The reason i'm nitpicking this is that eventually we want to auto generate changelogs & release notes from the commit messages. This only works if the conventional commit standard is properly adhered to.