Returned errors in Go are not checked or are ignored

[dnkolegov]

Many locations within the ​module​ subdirectory fail to check and handle returned errors and instead ignore them. Failing to check errors makes it difficult to discover or report the source of an error.

Unhandled errors:

• x/gravity/keeper/pool.go:194
• x/gravity/module.go:88
• x/gravity/abci.go:172
• x/gravity/abci.go:191

A returned error is ignored:

• x/gravity/abci.go:205
• x/gravity/abci.go:233
• x/gravity/abci.go:270
• x/gravity/abci.go:341
• x/gravity/abci.go:374
• x/gravity/abci.go:413
• x/gravity/abci.go:448
• x/gravity/keeper/genesis.go:120
• x/gravity/keeper/msg_server.go:49
• x/gravity/keeper/msg_server.go:50
• x/gravity/keeper/msg_server.go:51
• x/gravity/keeper/msg_server.go:90
• x/gravity/keeper/msg_server.go:173
• x/gravity/keeper/msg_server.go:184
• x/gravity/keeper/msg_server.go:223
• x/gravity/keeper/msg_server.go:249
• x/gravity/keeper/msg_server.go:297
• x/gravity/types/msgs.go:435
• x/gravity/types/msgs.go:492
• x/gravity/types/msgs.go:552
• x/gravity/types/msgs.go:625

[jkilpatr]

this is very helpful.

what linter did you use to get this list, I would love to add it to our setup.

[dnkolegov]

You can use the following:

• https://github.com/kisielk/errcheck
• https://github.com/golangci/golangci-lint
• https://github.com/dgryski/semgrep-go rules with semgrep

Look at this approach also https://github.com/prysmaticlabs/prysm/tree/develop/tools/analyzers