^ character in diff URLs prevents the whole URL from linkifying in some IRC clients

LeastAuthority / leastbot

0 stars 0 forks source link

^ character in diff URLs prevents the whole URL from linkifying in some IRC clients #11

Closed daira closed 10 years ago

daira commented 10 years ago

For example, https://github.com/LeastAuthority/leastbot/compare/56f6c2567934^...474b99846c85 does not linkify in AndChat, but https://github.com/LeastAuthority/leastbot/compare/56f6c2567934%5E...474b99846c85 does.

daira commented 10 years ago

Also, URLs with single quotes around them don't linkify correctly (in AndChat the closing quote is included in the URL). This affects messages such as

<leastbot> 'nathan-at-least' pushed 1 commits to 'refs/heads/6.release-process' of
'https://github.com/LeastAuthority/leastbot'

nathan-at-least commented 10 years ago

I'm going to attempt to fix both of these issues by url-encoding ^ and using python str interpolation instead of repr on URLs.

daira commented 10 years ago

Thanks!