search

LeastAuthority / python-challenge-bypass-ristretto

Python bindings for Brave's challenge-bypass-ristretto library
4 stars 4 forks source link

macOS wheel only targets macOS 10.15 #35

Closed crwood closed 3 years ago

crwood commented 3 years ago

The PyPI download files for this project offers a macOS wheel which targets macOS version 10.15 only. Users of older operating systems (such as macOS 10.14 -- which is still in widespread use and which still receives security updates from Apple) therefore cannot install this library from PyPI and must instead resort to fetching the source code manually, installing a rust compiler, and building from source.

It would be useful if the macos os matrix in the GitHub Actions workflow could be expanded to explicitly include the macos-10.14, macos-10.15, and macos-11.0 environments (each of which are available on GitHub Actions) and to drop the macos-latest (which points to whatever GHA considers current and is subject to change at any time). Judging by the other steps already in place in the existing GHA workflow config, this should facilitate the publishing of wheels to PyPI that target each of the currently supported macOS versions.

crwood commented 3 years ago

Hmm... Despite what is implied by the existence of this doc, it looks like GitHub Actions' macos-10.14 environment is (now?) just a pointer to macos-10.15 (and/or that, instead of executing a workflow on 10.14 proper, GHA will just silently spin up a 10.15 in its place):

macos

:/