Codecov Report

Merging #154 into master will decrease coverage by 0.19%. The diff coverage is 89.58%.

@@            Coverage Diff            @@
##           master     #154     +/-   ##
=========================================
- Coverage   94.38%   94.18%   -0.2%     
=========================================
  Files          25       25             
  Lines        2564     2580     +16     
  Branches      238      238             
=========================================
+ Hits         2420     2430     +10     
- Misses        112      119      +7     
+ Partials       32       31      -1

Impacted Files	Coverage Δ
src/txkube/testing/strategies.py	`84.37% <100%> (+0.33%)`	:arrow_up:
src/txkube/_authentication.py	`97.22% <100%> (+3.7%)`	:arrow_up:
src/txkube/test/test_authentication.py	`96.81% <84.37%> (-3.19%)`	:arrow_down:
src/txkube/testing/_testcase.py	`68% <0%> (-16%)`	:arrow_down:
src/txkube/test/test_model.py	`73.41% <0%> (-0.58%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1f3582a...f79d04d. Read the comment docs.

rodrigc commented 6 years ago

This is definitely a different approach than https://github.com/LeastAuthority/txkube/pull/152 , but looks better, so feel free to merge it.

I would have liked to get the patch in https://github.com/LeastAuthority/txkube/pull/152 working just to improve my understanding how the new TLS api changes in Twisted fit together, but that's not important.

exarkun commented 6 years ago

Coverage drop is a result of https://github.com/HypothesisWorks/hypothesis-python/issues/997 and (as far as I can tell) spurious. We'll want to fix that somehow but it has nothing to do with these changes. So, merging.

LeastAuthority / txkube

Factor `IPolicyForHTTPS` creation out and test it #154

Codecov Report