search

LeastAuthority / txkube

A Twisted-based Kubernetes client.
MIT License
12 stars 6 forks source link

Import twisted.python.compat to facilitate Python 3. #165

Closed rodrigc closed 6 years ago

rodrigc commented 6 years ago

Use long() instead of long literal to fix test on Python 3.

exarkun commented 6 years ago

What test?

rodrigc commented 6 years ago

The test is txkube.test.test_swagger.SwaggerTests.test_string_int_or_string

exarkun commented 6 years ago

test_swagger doesn't run on Python 3 yet, it seems, so I guess I shouldn't be looking at this.

rodrigc commented 6 years ago

Well I am providing incremental fixes to get towards Python 3, that are smaller for you to review and merge. There are a lot of interrelated fixes required to get test_swagger to work.

I got test_swagger to pass on Python 3 in this branch: https://github.com/LeastAuthority/txkube/pull/142

but there are a lot of interrelated fixes in there that haven't been merged, so I am submitting smaller fixes to get us to Python 3 tests working.

exarkun commented 6 years ago

So far, this is not easier to review.

rodrigc commented 6 years ago

If I combine these two patches:

https://github.com/LeastAuthority/txkube/pull/156 https://github.com/LeastAuthority/txkube/pull/165

into one patch, then I can get 34 out of 36 test_swagger tests passing on Python 3, versus zero now.

Do you want me to submit a single pull request with those two patches combined?

rodrigc commented 6 years ago

Moving patch to different pull request: https://github.com/LeastAuthority/txkube/pull/166