search

LeastAuthority / txkube

A Twisted-based Kubernetes client.
MIT License
12 stars 6 forks source link

Fix some tests in test_network on Python 3 #167

Closed rodrigc closed 6 years ago

rodrigc commented 6 years ago

With this patch, 8 out of 9 test_network tests pass on Python 3. The one failing test txkube.test.test_network.NetworkKubernetesFromContextTests.test_client_chain_certificate seems to be due to a bug in twisted.web on Python 3.

codecov-io commented 6 years ago

Codecov Report

Merging #167 into master will increase coverage by 0.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #167      +/-   ##
==========================================
+ Coverage   97.33%   97.34%   +0.01%     
==========================================
  Files          26       26              
  Lines        2703     2715      +12     
  Branches      247      251       +4     
==========================================
+ Hits         2631     2643      +12     
  Misses         43       43              
  Partials       29       29
Impacted Files Coverage Δ
src/txkube/test/test_swagger.py 97.72% <100%> (+0.03%) :arrow_up:
src/txkube/test/test_network.py 98.27% <100%> (+0.03%) :arrow_up:
src/txkube/_swagger.py 99.3% <100%> (ø) :arrow_up:
src/txkube/_network.py 98.4% <100%> (+0.01%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c4cb57f...d0bb045. Read the comment docs.

exarkun commented 6 years ago

Thanks. Looks good. Merging.