search

Leather128 / LeatherEngine

Just a little engine I decided to make since nobody seemed to have true custom mod support.
GNU General Public License v3.0
71 stars 57 forks source link

Bug(?) Report: Dropped sustains are not fully punished #70

Closed daisukidaisy closed 2 years ago

daisukidaisy commented 2 years ago

If you drop a sustain (as of most recent release), the game will subtract 10 points per 16th(?) as it should, but it will not count as a combo break nor will it drop your accuracy. Generally, dropping a sustain should be punishable, as this is not Clone Hero.

Onemario1234 commented 2 years ago

Accuracy I think it should lower, but I don't think it should increase the number of misses. I feel it makes sense if missing any point of a sustain note would count as only one miss.

Leather128 commented 2 years ago

Dropped sustains are not fully punished as of now, because I am planning a rework that combines all the parts of a sustain note into one (because right now they are seperate sections) and having each section give a miss would be unfair. This will be fixed when I rework them.

Leather128 commented 2 years ago

I must add however, they are still supposed to drop your accuracy.

Leather128 commented 2 years ago

Checked on the most recent commits, sustain notes lower accuracy. So I guess part of this issue is out of date.

Leather128 commented 2 years ago

Fixed in #5683375. Also added an option to turn off gaining misses from held notes because why not. Also also, I made you get a miss only once from missing a sustain note (because before it would give a miss for each sustain note section).