LeavesMC / Leaves

Fork of Paper aimed at repairing broken vanilla properties.
https://leavesmc.org
Other
379 stars 39 forks source link

[Vote] Remove most optimizations from Leaves #262

Closed s-yh-china closed 1 month ago

s-yh-china commented 1 month ago

In the early stages of 'leaves', we added certain optimizations. As of today, these optimizations may benefit the server-side, but they have significantly slowed down our development process. Now, I propose to remove most of the optimizations in 'leaves', leaving only necessary, significant and non-intrusive ones. If removed, the optimized part might become an independent 'Leaves fork'. This is a vote, not an announcement, you can voice your opinion through emoticons or leave a comment below.

Chinese version: 在早期的leaves中,我们曾加入了一定的优化。时至今日,这些优化可能对服务端有益处,但这大大拖慢了我们开发的进程。 在现在,我提出移除leaves中的大部分优化,只留下一些必要的,效果显著的,且不影响原版的。如果移除,优化的部分可能会成为一个单独的 Leaves fork 而存在。 这是一个投票,而不是一个公告,你可以使用表情符号发表你的意见,或者在下方留言。

lilingfengdev commented 1 month ago

This is a great decision.

Most users of Leaves don't care about performance, they are looking for stock features and module support, ditching the performance optimisation patches will allow Leaves to focus on features and module support.

(and Leaf) 😄

MC-XiaoHei commented 1 month ago

我认为这很好,保留大量效果不显著且可能破坏特性的优化并不是好的选择 I think that's fine, it's not a good idea to keep a lot of optimizations that are insignificant and may break features

如果需要更好的优化,可以期待Lumina If you need better optimization, you can look forward to Lumina

LittleChest commented 1 month ago

Great! Let's do more meaningful things. If you need optimizations, you can check out some other forks (such as Leaf). 同名叶子

Lumine1909 commented 1 month ago

FOCUS ON FEATURES!

Lu-Mine commented 1 month ago

非常支持。这大大减小了新服务端配置负担。 Much in favor of this! This greatly reduces the burden of configuring a new server.

“开箱即用”正是 Leaves 核心所追求的。 Out of the box = exactly what Leaves is all about, isn't it?

CerealAxis commented 1 month ago

Good

Lumine1909 commented 1 month ago

非常支持。这大大减小了新服务端配置负担。 Much in favor of this! This greatly reduces the burden of configuring a new server.

“开箱即用”正是 Leaves 核心所追求的。 Out of the box = exactly what Leaves is all about, isn't it?

good user id (

theLIKImk commented 1 month ago

支持 .....怎么说呢,其实由于原版服务端是单核服务器,不管再怎么优化上线都是那样了(CPU-Z单核心670分的运行MC的情况都不是很理想)。 要更多优化只能期待......多线程服务端吧。

Lu-Mine commented 1 month ago

支持 .....怎么说呢,其实由于原版服务端是单核服务器,不管再怎么优化上线都是那样了(CPU-Z单核心670分的运行MC的情况都不是很理想)。 要更多优化只能期待......多线程服务端吧。

期待(Expect) Lumina.

xiao-k233 commented 1 month ago

从Leaf里偷一些效果最显著的patch来? 例如AVX支持?

s-yh-china commented 1 month ago

从Leaf里偷一些效果最显著的patch来? 例如AVX支持?

读书人的事,能叫偷吗

Bluemangoo commented 1 month ago

支持 .....怎么说呢,其实由于原版服务端是单核服务器,不管再怎么优化上线都是那样了(CPU-Z单核心670分的运行MC的情况都不是很理想)。 要更多优化只能期待......多线程服务端吧。

有没有优化差别相当大。

LittleChest commented 1 month ago

从Leaf里偷一些效果最显著的patch来? 例如AVX支持?

我们的开发重点不在优化,而且这仍然会拖慢开发速度。

Bluemangoo commented 1 month ago

从Leaf里偷一些效果最显著的patch来? 例如AVX支持?

今天的 update paper 应该让你来。

xiao-k233 commented 1 month ago

别骂了别骂了

---Original--- From: @.> Date: Fri, Jul 19, 2024 22:09 PM To: @.>; Cc: @.**@.>; Subject: Re: [LeavesMC/Leaves] [Vote] Remove most optimizations from Leaves(Issue #262)

从Leaf里偷一些效果最显著的patch来? 例如AVX支持?

今天的 update paper 应该让你来。

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>

xiao-k233 commented 1 month ago

但是生电确是最吃优化的

---Original--- From: @.> Date: Fri, Jul 19, 2024 22:08 PM To: @.>; Cc: @.**@.>; Subject: Re: [LeavesMC/Leaves] [Vote] Remove most optimizations from Leaves(Issue #262)

从Leaf里偷一些效果最显著的patch来? 例如AVX支持?

我们的开发重点不在优化,而且这仍然会拖慢开发速度。

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>

LrbsX commented 1 month ago

那扔掉不显著的优化会跟原先paper的性能差的大么🤔

MC-XiaoHei commented 1 month ago

那扔掉不显著的优化会跟原先paper的性能差的大么🤔

这要看你怎么定义 差的大

实际上在我看来leaves的性能从来都不是一个很好的卖点(诋毁

s-yh-china commented 1 month ago

那扔掉不显著的优化会跟原先paper的性能差的大么🤔

怎么都是基于paper 我觉得应该不会?

MC-XiaoHei commented 1 month ago

那扔掉不显著的优化会跟原先paper的性能差的大么🤔

怎么都是基于paper 我觉得应该不会?

我感觉leaves有一些功能具有未知的破坏性能的作用(

毕竟现在看起来leaves确实性能比paper差

Bluemangoo commented 1 month ago

我们把一些大幅优化(破坏)的patch还原了。当然性能会下降。

s-yh-china commented 1 month ago

很明显大家都不反对,我们即将执行(笑)

xiao-k233 commented 1 month ago

我反对[doge]把一些最好的补丁拿过来,能打就打,不能打算了,等别人维护好了再合

LittleChest commented 1 month ago

我反对[doge]把一些最好的补丁拿过来,能打就打,不能打算了,等别人维护好了再合

你自己fork一个 想合什么合什么

Mooling0602 commented 1 month ago

优化的部分可能会成为一个单独的 Leaves fork 而存在

只是“可能”,也就是说有概率后面这些优化都有概率在新版本消失,因此我反对,另外关闭 issue 的速度不要太快了吧) 至于说 Folia 那种类型的服务端,我个人而言暂不会考虑,因为多线程的服务端要兼容现有的插件生态或许还需要较长的时间。

s-yh-china commented 1 month ago

优化的部分可能会成为一个单独的 Leaves fork 而存在

只是“可能”,也就是说有概率后面这些优化都有概率在新版本消失,因此我反对,另外关闭 issue 的速度不要太快了吧) 至于说 Folia 那种类型的服务端,我个人而言暂不会考虑,因为多线程的服务端要兼容现有的插件生态或许还需要较长的时间。

因为确实没人提出反对(

Mooling0602 commented 1 month ago

优化的部分可能会成为一个单独的 Leaves fork 而存在

只是“可能”,也就是说有概率后面这些优化都有概率在新版本消失,因此我反对,另外关闭 issue 的速度不要太快了吧) 至于说 Folia 那种类型的服务端,我个人而言暂不会考虑,因为多线程的服务端要兼容现有的插件生态或许还需要较长的时间。

因为确实没人提出反对(

异议!doge

s-yh-china commented 1 month ago

那我们再开几天(

MC-XiaoHei commented 1 month ago

我反对[doge]把一些最好的补丁拿过来,能打就打,不能打算了,等别人维护好了再合

那你来写。

MC-XiaoHei commented 1 month ago

Reference in n

上面有emoji投票

mc506lw commented 1 month ago

So cool!It was a great decision ahead of time!

MC-XiaoHei commented 1 month ago

So cool!It was a great decision ahead of time!

also see https://github.com/LeavesMC/Lumina/discussions/16 plz XD

yxc0915 commented 1 month ago

对于我来说,只要能够满足生电需求就行()ps:我用leaves开个小型生电服tps都只有10几,给我整不会了(CPU是13900)🌚🌚🌚

LittleChest commented 1 month ago

对于我来说,只要能够满足生电需求就行()ps:我用leaves开个小型生电服tps都只有10几,给我整不会了(CPU是13900)🌚🌚🌚

尝试使用11/12代英特尔CPU,13代英特尔CPU有质量问题

Bluemangoo commented 1 month ago

对于我来说,只要能够满足生电需求就行()ps:我用leaves开个小型生电服tps都只有10几,给我整不会了(CPU是13900)🌚🌚🌚

尝试使用11/12代英特尔CPU,13代英特尔CPU有质量问题

最新intel回复包赔。

Noogear commented 1 month ago

让我想到了一个端 https://github.com/Winds-Studio/Leaf 它就像是paper优化集合的分支

MC-XiaoHei commented 1 month ago

让我想到了一个端 https://github.com/Winds-Studio/Leaf 它就像是paper优化集合的分支

leaf开发者和我们很熟(x

qyl27 commented 1 month ago

LGTM, I would like vanilla features rather than optimizations.

s-yh-china commented 1 month ago

我们注意到,并没有那么多用户支持保留优化,因此我们即将开始进行此issue