Leclowndu93150 / Nomi-CEu-Modern

Port of Nomi-CEu to newer versions!
GNU Lesser General Public License v3.0
0 stars 1 forks source link

On mac, crashes when creating a new world/accessing new world #227

Closed WeebOfearth closed 7 months ago

WeebOfearth commented 7 months ago

When you download and import the latest pack directly to curse, it crashes on launch with exit code -1. On second launch, it loads properly. When you create a new world, it crashes with exit code -9. When re-launching, the world exists, but when opening the world it crashes with exit code -9.

Upon deleting the profile, and attempting again, the issue persists.

Logs on initial startup: 12:03:29] [main/ERROR]: Critical injection failure: LVT in net/minecraft/client/renderer/entity/ItemRenderer::m115143(Lnet/minecraft/world/item/ItemStack;Lnet/minecraft/world/item/ItemDisplayContext;ZLcom/mojang/blaze3d/vertex/PoseStack;Lnet/minecraft/client/renderer/MultiBufferSource;IILnet/minecraft/client/resources/model/BakedModel;)V has incompatible changes at opcode 356 in callback avaritia.mixins.json:ItemRendererMixin from mod avaritia->@Inject::onRender(Lnet/minecraft/world/item/ItemStack;Lnet/minecraft/world/item/ItemDisplayContext;ZLcom/mojang/blaze3d/vertex/PoseStack;Lnet/minecraft/client/renderer/MultiBufferSource;IILnet/minecraft/client/resources/model/BakedModel;Lorg/spongepowered/asm/mixin/injection/callback/CallbackInfo;ZZLjava/util/Iterator;Lnet/minecraft/client/resources/model/BakedModel;Ljava/util/Iterator;Lnet/minecraft/client/renderer/RenderType;Lcom/mojang/blaze3d/vertex/VertexConsumer;)V. Expected: [Z, Z, Ljava/util/Iterator;, Lnet/minecraft/client/resources/model/BakedModel;, Ljava/util/Iterator;, Lnet/minecraft/client/renderer/RenderType;, Lcom/mojang/blaze3d/vertex/VertexConsumer;] Found: [Z, Z, Lnet/minecraft/world/level/block/Block;, Lnet/minecraft/client/resources/model/BakedModel;, Lnet/minecraft/client/renderer/RenderType;, Lcom/mojang/blaze3d/vertex/VertexConsumer;, Lcom/mojang/blaze3d/vertex/PoseStack$Pose;] Available: [Z, Z, Lnet/minecraft/world/level/block/Block;, Lnet/minecraft/client/resources/model/BakedModel;, Lnet/minecraft/client/renderer/RenderType;, Lcom/mojang/blaze3d/vertex/VertexConsumer;, Lcom/mojang/blaze3d/vertex/PoseStack$Pose;]

Leclowndu93150 commented 7 months ago

restart the modpack or downgrade java to 17.0.6

glektarssza commented 7 months ago

I've run into this on Windows too. Seems related to the Avaritia mod, as evidenced by the incompatible changes at opcode 356 in callback avaritia.mixins.json:ItemRendererMixin from mod avaritia log line. Disabling that mod allows the modpack to start but I'm not sure what other effects it might have.

@WeebOfearth Can you please confirm that disabling that particular mod lets the modpack start?

@ThePansmith What is Avaritia used for in this pack?

Leclowndu93150 commented 7 months ago

it's literally part of the modpack

glektarssza commented 7 months ago

it's literally part of the modpack

@Leclowndu93150 Yes but what is it used for in this modpack? If it's causing the pack to crash then that needs to be looked into.

Leclowndu93150 commented 7 months ago

it's literally part of the modpack

@Leclowndu93150 Yes but what is it used for in this modpack? If it's causing the pack to crash then that needs to be looked into.

it only happens to 1% of the players, i have no clue whats the issue and the dev is not in a good health rn

glektarssza commented 7 months ago

it's literally part of the modpack

@Leclowndu93150 Yes but what is it used for in this modpack? If it's causing the pack to crash then that needs to be looked into.

it only happens to 1% of the players, i have no clue whats the issue and the dev is not in a good health rn

While I have great sympathy for the mod developer being unwell at this time that doesn't answer my question. What is the mod used for in this modpack? If you don't know that's okay. I'm just trying to figure out what an appropriate fix for this issue would be.

Leclowndu93150 commented 7 months ago

If you don't know that's okay.

I am the Creator of the modpack so i do know everything in it and to anwser, it is used for End Game, if you remove the mod you CANNOT play the modpack and most scripts won't even load

glektarssza commented 7 months ago

may i remind you that i'm the one that created the modpack.

That was not meant to be a jab at you and I apologize if it came across that way.

it is used for End Game, if you remove the mod you CANNOT play the modpack and most scripts won't even load

Okay, good to know. I've had success with getting the modpack to load without the mod installed when this issue happens but if it's going to break the end game then that's not a valid solution, I agree.

Leclowndu93150 commented 7 months ago

may i remind you that i'm the one that created the modpack.

That was not meant to be a jab at you and I apologize if it came across that way.

it is used for End Game, if you remove the mod you CANNOT play the modpack and most scripts won't even load

Okay, good to know. I've had success with getting the modpack to load without the mod installed when this issue happens but if it's going to break the end game then that's not a valid solution, I agree.

not only the end game but the entirety of it, sadly. if you could give me more info about your system and Java version i could help

WeebOfearth commented 7 months ago

may i remind you that i'm the one that created the modpack.

That was not meant to be a jab at you and I apologize if it came across that way.

it is used for End Game, if you remove the mod you CANNOT play the modpack and most scripts won't even load

Okay, good to know. I've had success with getting the modpack to load without the mod installed when this issue happens but if it's going to break the end game then that's not a valid solution, I agree.

not only the end game but the entirety of it, sadly. if you could give me more info about your system and Java version i could help

My apologies for not replying in a practical timeframe. I will have that information shortly. I had no intention to spark controversy or issues in regards to this particular concern I had, rather I just wanted to ensure there was awareness of it present.

Leclowndu93150 commented 7 months ago

it's all good dw

WeebOfearth commented 7 months ago

Currently running java 1.8.0_391. Updating now to see if issue is resolved.

Leclowndu93150 commented 7 months ago

you need java 17.. and if you ran java -version it will default to 8 soo

Leclowndu93150 commented 7 months ago

@glektarssza @WeebOfearth https://legacy.curseforge.com/minecraft/mc-mods/lazurite/files/5213023 would installing this mod fix the issue ?

glektarssza commented 7 months ago

@glektarssza @WeebOfearth https://legacy.curseforge.com/minecraft/mc-mods/lazurite/files/5213023 would installing this mod fix the issue ?

Maybe? I'll give it a try after work today and also let you know what my system setup is (Java version, operating system, etc).

glektarssza commented 7 months ago

Quick update on my system:

Minecraft: 1.20.1 LWJGL: 3.3.1 Forge: 47.2.20 Java:

openjdk version "17.0.10" 2024-01-16
OpenJDK Runtime Environment Temurin-17.0.10+7 (build 17.0.10+7)
OpenJDK 64-Bit Server VM Temurin-17.0.10+7 (build 17.0.10+7, mixed mode, sharing)

JVM Arguments:

-XX:+UseG1GC -Dsun.rmi.dgc.server.gcInterval=2147483646 -XX:+UnlockExperimentalVMOptions -XX:G1NewSizePercent=20 -XX:G1ReservePercent=20 -XX:MaxGCPauseMillis=50 -XX:G1HeapRegionSize=32M --add-opens=java.base/sun.security.util=ALL-UNNAMED --add-opens=java.base/java.util.jar=ALL-UNNAMED -XX:+IgnoreUnrecognizedVMOptions

Operating System: Windows 11 Architecture: 64-bit

I've allocated Minecraft 8GB of RAM.

glektarssza commented 7 months ago

Tried adding Lazurite to the modpack, @Leclowndu93150. Still crashes with the same error for me.

Leclowndu93150 commented 7 months ago

Tried adding Lazurite to the modpack, @Leclowndu93150. Still crashes with the same error for me.

Downgrade Java to 17.0.6

glektarssza commented 7 months ago

Tried adding Lazurite to the modpack, @Leclowndu93150. Still crashes with the same error for me.

Downgrade Java to 17.0.6

Will try after dinner and report back.

Leclowndu93150 commented 7 months ago

You forgor

glektarssza commented 7 months ago

You forgor

I got busy with some other stuff.

Jaymus3 commented 7 months ago

I was running java 17.0.2 on Mac OS and confirmed that upgrading to 17.0.6 allows the pack to launch. Is this an avaritia issue?

Leclowndu93150 commented 7 months ago

I was running java 17.0.2 on Mac OS and confirmed that upgrading to 17.0.6 allows the pack to launch. Is this an avaritia issue?

maybe, maybe not, the Avaritia dev has health issues rn and can't work on it

glektarssza commented 7 months ago

I was running java 17.0.2 on Mac OS and confirmed that upgrading to 17.0.6 allows the pack to launch. Is this an avaritia issue?

I suspect it is given the error log that gets spat out. Something about the version of Java the mod was compiled with versus the version of Java being used to run the modpack. Seems Java 17.0.6 works but other versions do not which makes sense given the error message about an invalid opcode.