Unzip: Dummy file is created when password is invalid - Githubissues

Lecrapouille / zipper

[Lib][Version 2.1.0][Functional] C++ wrapper around minizip compression library

MIT License

66 stars 13 forks source link

Unzip: Dummy file is created when password is invalid #6

Open Lecrapouille opened 1 year ago

Lecrapouille commented 1 year ago

@fbergmann

Let supposed foo.zip has "1234" as password.
Let try opening it with "abcd" password and try to extract all its entries.
unzOpenCurrentFilePassword with "abcd" password does not return KO
std::ofstream output_file(filename.c_str(), std::ofstream::binary); The file of the entry is created with some bytes inside (because set as binary ?)
unzReadCurrentFile will return 0 bytes read (instead of negative value for error).
extractToXXX is returning OK
unzCloseCurrentFile is returning KO
ofstream file is still present.

Lecrapouille commented 1 year ago

Get segfault with macOS when dezziping https://www.unforgettable.dk/ with dummy password