search

LederCards / cards

8 stars 5 forks source link

Add "Power" tag to more cards. #12

Closed Simwarden closed 4 months ago

Simwarden commented 4 months ago

I'm assuming that this tag is meant for cards that have an icon cost to use its power. In that case the following cards were missing that tag: Convoys Fae Merchant War Tortoise

The name of this tag is a bit confusing since Power is a much broader term in Oath. Maybe something like "Cost" would be more fitting?

seiyria commented 4 months ago

Yeah, I'm not super sure what my thought process was when I did this. I think it is as you suggest: cards that have abilities. I'd probably suggest Ability over Cost as I find it to be more descriptive, but getting them all to be tagged correctly is a great first place to start.

Simwarden commented 4 months ago

I see, but if it's meant to be from an ability perspective, shouldn't all the free abilities be added as well? Right now, the tag just indicates which cards that has abilities with a cost.

From: Kyle J. Kemp @.> Sent: Monday, June 24, 2024 02:20 To: LederCards/cards @.> Cc: Simwar @.>; Author @.> Subject: Re: [LederCards/cards] Add "Power" tag to more cards. (PR #12)

Yeah, I'm not super sure what my thought process was when I did this. I think it is as you suggest: cards that have abilities. I'd probably suggest Ability over Cost as I find it to be more descriptive, but getting them all to be tagged correctly is a great first place to start.

— Reply to this email directly, view it on GitHubhttps://github.com/LederCards/cards/pull/12#issuecomment-2185379608, or unsubscribehttps://github.com/notifications/unsubscribe-auth/APOMHFUUOSQNQLNDT2XQEYLZI5Q6PAVCNFSM6AAAAABJYZQ352VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBVGM3TSNRQHA. You are receiving this because you authored the thread.Message ID: @.***>

seiyria commented 4 months ago

Perhaps. My original usage was not super granular, it was mostly to sort oathcards.seiyria.com a little bit. I think I would defer to what is most useful. Paid ability + Free ability + ability tags if that level of granularity is what makes sense.

Simwarden commented 4 months ago

That however raises the question; what is an ability? Since that is not a term defined in Oath. Some of them are activated, some of them are passive, some of them are free, some of them are paid for and some are used when played. You could argue that all denizen cards are abilities. I think it would make more sense to just distinguish between:

  1. Are they Battle Plans.

  2. Do they modify an action (I think this is what you refer to as ability tag). If so, which one: Travel, Trade, Muster, Recover, Campaign and Search.

From: Kyle J. Kemp @.> Sent: Monday, June 24, 2024 02:48 To: LederCards/cards @.> Cc: Simwar @.>; Author @.> Subject: Re: [LederCards/cards] Add "Power" tag to more cards. (PR #12)

Perhaps. My original usage was not super granular, it was mostly to sort oathcards.seiyria.com a little bit. I think I would defer to what is most useful. Paid ability + Free ability + ability tags if that level of granularity is what makes sense.

— Reply to this email directly, view it on GitHubhttps://github.com/LederCards/cards/pull/12#issuecomment-2185395035, or unsubscribehttps://github.com/notifications/unsubscribe-auth/APOMHFTSE3EMFQBRAHVFYQDZI5UFHAVCNFSM6AAAAABJYZQ352VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBVGM4TKMBTGU. You are receiving this because you authored the thread.Message ID: @.***>

seiyria commented 4 months ago

I'm pretty flexible here. If you wanted to ask for some feedback in discord and perhaps retag the collection, maybe some input from @ledergamesmatt would be welcome here.