search

LedgerHQ / app-bitcoin-new

Modern Bitcoin Application based on PSBT and Descriptors
Apache License 2.0
94 stars 72 forks source link

Update Rust client library for tapscript support #105

Closed bigspider closed 1 year ago

bigspider commented 1 year ago

When signing tapscript transactions, the SIGN_PSBT command returns pubkey||tapleaf_hash instead of just pubkey. Cient library would be cleaner by replacing the older pubkey object with a structured object that always contains a pubkey (33-bytes if non-taproot, 32 byte if taproot) and optionally the tapleaf_hash (for taproot scripts only).

This is a breaking change for the client library, so it needs to be respected with the semver versioning.

hs094 commented 1 year ago

Hi, Can i take up this issue?

bigspider commented 1 year ago

Done in #139.