search

LedgerHQ / app-bitcoin-new

Modern Bitcoin Application based on PSBT and Descriptors
Apache License 2.0
94 stars 72 forks source link

Use image compiled the latest bitcoin-core instead of a custom fork #199

Closed bigspider closed 1 year ago

bigspider commented 1 year ago

Now that bitcoin-core has full miniscript support, we no longer need to use a custom branch for e2e tests.

codecov-commenter commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (3dab7df) 84.27% compared to head (a8fce7c) 84.27%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #199 +/- ## ======================================== Coverage 84.27% 84.27% ======================================== Files 17 17 Lines 2168 2168 ======================================== Hits 1827 1827 Misses 341 341 ``` | [Flag](https://app.codecov.io/gh/LedgerHQ/app-bitcoin-new/pull/199/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LedgerHQ) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/LedgerHQ/app-bitcoin-new/pull/199/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LedgerHQ) | `84.27% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LedgerHQ#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bigspider commented 1 year ago

TBC once bitcoin v26.0 is published here; needs to be updated in the Dockerfile.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.3) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. Read more here

bigspider commented 1 year ago

On second thought, a8fce7cdf4fed3c04b8805796df9e58f8cec504a compiles bitcoin-core from github instead of using a specific tagged release.

The chance of changes to the bitcoin-core wallet that break the e2e tests is quite low, and if that were to happen, we probably want to know as soon as possible, rather than waiting for the next tagged release of bitcoin-core.